feat(ratings): Add Python implementation for Elo Expected Score formula#13458
Closed
Navodhya-Fernando wants to merge 2 commits intoTheAlgorithms:masterfrom
Closed
feat(ratings): Add Python implementation for Elo Expected Score formula#13458Navodhya-Fernando wants to merge 2 commits intoTheAlgorithms:masterfrom
Navodhya-Fernando wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Navodhya-Fernando
force-pushed
the
master
branch
from
00d707a to
37eb3ad
Compare
algorithms-keeper
bot
added
the
require type hints
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| exponent = (rating_b - rating_a) / 400 | ||
| return 1.0 / (1.0 + math.pow(10, exponent)) | ||
|
|
||
| def test_calculate_elo_expected_score(): |
There was a problem hiding this comment.
Please provide return type hint for the function: test_calculate_elo_expected_score. If the function does not return a value, please provide the type hint as: def function() -> None:
for more information, see https://pre-commit.ci
Member
|
Closing require_type_hints PRs to prepare for Hacktoberfest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Feature: Implement the Elo Expected Score Formula
📋 Description
This PR introduces the
calculate_elo_expected_scorefunction to the math section. This function is a core component of the widely used Elo Rating System, which determines the expected outcome of a match between two players based on their current ratings.⚽ Why This Matters (Sports Industry Relevance)
This algorithm is directly applicable to statistical analysis in many competitive fields, including:
🔧 What's Added
maths/elo_expected_score.pycalculate_elo_expected_score(rating_a, rating_b)import mathand a basicif __name__ == '__main__'usage example.✅ Checklist
if __name__ == '__main__':).maths).🎃 Hacktoberfest 2025
This is submitted as a high-quality contribution, adding a practical and mathematically significant algorithm to the collection.